feat: impl BatchDelete
#1253
Merged
feat: impl BatchDelete
#1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
requested review from
sunng87,
MichaelScofield,
fengjiachun and
fengys1996
shuiyisong
commented
Mar 27, 2023
|
The corresponding |
Codecov Report
@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
- Coverage 85.64% 85.11% -0.53%
===========================================
Files 495 495
Lines 73428 73629 +201
===========================================
- Hits 62887 62672 -215
- Misses 10541 10957 +416 |
@Fengys123 It's added now, PTAL |
shuiyisong
force-pushed
the
feat/batch_delete
branch
from
df686f8 to
d3c1c39
Compare
|
There is some conflicts, please resolve it. @shuiyisong 😃 |
shuiyisong
force-pushed
the
feat/batch_delete
branch
from
d3c1c39 to
eb6366c
Compare
|
@Fengys123 Rebased, PTAL 😆 |
MichaelScofield
approved these changes
Mar 28, 2023
Co-authored-by: LFC <bayinamine@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: impl `BatchDelete` * chore: add `batch_delete` to meta-client * fix: auth param length check * fix: auth param length check * chore: rebase develop * chore: use `filter_map` Co-authored-by: LFC <bayinamine@gmail.com> * chore: update error msg Co-authored-by: LFC <bayinamine@gmail.com> * fix: pre-allocate vec length --------- Co-authored-by: LFC <bayinamine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly implements
BatchDeleteonkv_storeChecklist
Refer to a related PR or issue link (optional)
#1249