feat!: improve region manifest service #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
added
the
breaking-change
github-actions
bot
removed
the
breaking-change
killme2008
force-pushed
the
feature/tweak-region-manifest
branch
from
57c7849 to
86ea620
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1268 +/- ##
===========================================
- Coverage 85.65% 85.43% -0.22%
===========================================
Files 495 496 +1
Lines 73416 74518 +1102
===========================================
+ Hits 62882 63667 +785
- Misses 10534 10851 +317 |
killme2008
requested review from
v0y4g3r,
evenyag,
MichaelScofield and
waynexia
killme2008
added
the
breaking-change
github-actions
bot
removed
the
breaking-change
killme2008
changed the title
github-actions
bot
added
the
breaking-change
Co-authored-by: LFC <bayinamine@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
evenyag
reviewed
Mar 30, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
|
@evenyag @MichaelScofield PTAL |
evenyag
reviewed
Mar 30, 2023
MichaelScofield
approved these changes
Mar 30, 2023
evenyag
approved these changes
Mar 31, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: try to use batch delete in ManifestLogStorage * feat: clean temp dir when startup with file backend * refactor: export region manifest checkpoint actions magin and refactor storage options * feat: purge unused manifest and checkpoint files by repeat gc task * chore: debug deleted logs * feat: adds RepeatedTask and refactor all gc tasks * chore: clean code * feat: export gc_duration to manifest config * test: assert gc works * fix: typo * Update src/common/runtime/src/error.rs Co-authored-by: LFC <bayinamine@gmail.com> * Update src/common/runtime/src/repeated_task.rs Co-authored-by: LFC <bayinamine@gmail.com> * Update src/common/runtime/src/repeated_task.rs Co-authored-by: LFC <bayinamine@gmail.com> * fix: format * Update src/common/runtime/src/repeated_task.rs Co-authored-by: Yingwen <realevenyag@gmail.com> * chore: by CR comments * chore: by CR comments * fix: serde default for StorageConfig * chore: remove compaction config in StandaloneOptions --------- Co-authored-by: LFC <bayinamine@gmail.com> Co-authored-by: Yingwen <realevenyag@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Main changes:
RepeatedTaskto run the repeated task with an interval.Refactor some code.atomic_write_dirdir when using the local file system as storage at startup.[compaction]section to[storage.compaction].[storage.manifest]to configure region manifest service.Checklist
Refer to a related PR or issue link (optional)