feat: unify describe table execution #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
requested review from
killme2008,
sunng87,
fengjiachun and
v0y4g3r
sunng87
approved these changes
Mar 30, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1285 +/- ##
===========================================
- Coverage 85.91% 85.51% -0.40%
===========================================
Files 494 494
Lines 74263 74709 +446
===========================================
+ Hits 63804 63889 +85
- Misses 10459 10820 +361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Make "describe table" SQL executed at Frontend instance.
Part of #1010.
After this PR, I think there are no more statements that should be rewritten to be executed in query engine. What's left stmts are all differently handled in distributed and standalone modes, can't be unified.
Checklist
Refer to a related PR or issue link (optional)