fix: checkpoint fails when deleting old logs fails #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
force-pushed
the
fix/manifest-purge
branch
from
795fcaf to
c9113da
Compare
killme2008
requested review from
MichaelScofield,
fengjiachun,
v0y4g3r,
evenyag and
waynexia
Codecov Report
@@ Coverage Diff @@
## develop #1300 +/- ##
===========================================
- Coverage 85.88% 85.46% -0.43%
===========================================
Files 500 501 +1
Lines 75756 75862 +106
===========================================
- Hits 65066 64834 -232
- Misses 10690 11028 +338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The old manifest logs may be deleted by GC task simultaneously with
do_checkpoint, then cause checkpointing to fail. But it doesn't matter when deleting manifest logs fails in checkpointing, they will be purged by GC task.Checklist
Refer to a related PR or issue link (optional)