Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak logs #1314

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Simplify log output #1217

Not totally finished.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 marked this pull request as ready for review April 3, 2023 08:34
@killme2008 killme2008 requested review from v0y4g3r and evenyag and removed request for v0y4g3r April 3, 2023 08:39
@killme2008 killme2008 force-pushed the feature/tweak-logs branch from b11e8b8 to bd75903 Compare April 3, 2023 08:39
@killme2008 killme2008 requested review from v0y4g3r and waynexia April 3, 2023 08:39
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1314 (f069f1c) into develop (48c2841) will decrease coverage by 0.39%.
The diff coverage is 86.95%.

@@             Coverage Diff             @@
##           develop    #1314      +/-   ##
===========================================
- Coverage    85.76%   85.38%   -0.39%     
===========================================
  Files          502      504       +2     
  Lines        76130    76320     +190     
===========================================
- Hits         65294    65164     -130     
- Misses       10836    11156     +320     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/storage/src/sst.rs Outdated Show resolved Hide resolved
@killme2008 killme2008 merged commit 68d3247 into GreptimeTeam:develop Apr 3, 2023
@killme2008 killme2008 deleted the feature/tweak-logs branch April 3, 2023 13:08
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* chore: tweak logs

* chore: cr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants