Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement deriv function #1324

Merged
merged 3 commits into from
Apr 5, 2023
Merged

feat: implement deriv function #1324

merged 3 commits into from
Apr 5, 2023

Conversation

haohuaijin
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

I implement the deriv function in PromQL and add some unit test.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1227

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #1324 (cc9c769) into develop (2458b4e) will decrease coverage by 0.39%.
The diff coverage is 94.93%.

@@             Coverage Diff             @@
##           develop    #1324      +/-   ##
===========================================
- Coverage    85.82%   85.43%   -0.39%     
===========================================
  Files          504      506       +2     
  Lines        76288    76782     +494     
===========================================
+ Hits         65473    65601     +128     
- Misses       10815    11181     +366

waynexia
waynexia approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! thanks @haohuaijin ❤️

@waynexia waynexia requested review from killme2008 and yuanbohan April 4, 2023 14:23
killme2008
killme2008 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/promql/src/functions/deriv.rs Show resolved Hide resolved
@killme2008 killme2008 enabled auto-merge (squash) April 4, 2023 15:30
@killme2008 killme2008 disabled auto-merge April 4, 2023 15:30
@MichaelScofield MichaelScofield merged commit a6932c6 into GreptimeTeam:develop Apr 5, 2023
@haohuaijin haohuaijin deleted the deriv branch April 5, 2023 12:34
@waynexia waynexia mentioned this pull request Apr 6, 2023
Closed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@haohuaijin @paomian
feat: implement deriv function (GreptimeTeam#1324)
fe55615 
* feat: implement deriv function

* docs: add docs for linear regression

* test: add test for deriv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

@yuanbohan yuanbohan Awaiting requested review from yuanbohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haohuaijin @killme2008 @waynexia @MichaelScofield