Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename "value" semantic type to "field" #1326

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Apr 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr replaces "value_column" with "field_column" globally, and updated the corresponding describe_table utility accordingly.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

waynexia added 3 commits April 4, 2023 18:44
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested review from killme2008 and v0y4g3r April 4, 2023 10:53
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 enabled auto-merge (squash) April 4, 2023 10:58
@waynexia waynexia requested a review from MichaelScofield April 4, 2023 10:58
@killme2008 killme2008 merged commit 99353c6 into GreptimeTeam:develop Apr 4, 2023
@waynexia waynexia deleted the rename-value branch April 4, 2023 12:20
@waynexia waynexia mentioned this pull request Apr 4, 2023
2 tasks
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* global replace

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* change desc table

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* update sqlness result

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants