fix: stream inserts when copying from external file #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1338 +/- ##
===========================================
- Coverage 85.82% 85.42% -0.40%
===========================================
Files 504 506 +2
Lines 76288 76904 +616
===========================================
+ Hits 65473 65697 +224
- Misses 10815 11207 +392 |
MichaelScofield
approved these changes
Apr 7, 2023
Co-authored-by: LFC <bayinamine@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: stream inserts when copying from external file * fix: reset pending bytes once insertion succeeds * Update src/datanode/src/sql/copy_table_from.rs Co-authored-by: LFC <bayinamine@gmail.com> --------- Co-authored-by: LFC <bayinamine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
This PR changes the behavior when copying data from external file into tables.
Instead of reading all rows from all files into memory and writing them into tables at a time, now rows are written into tables as soon as memory consumption reaches a predefined threshold.
This may helps to reduce memory consumption when importing a large file like in this thread.
Checklist
Refer to a related PR or issue link (optional)