feat: from/to numpy&collect concat #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 874 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 672 | 1 | 201 | 0 |
Click to see the invalid file list
- src/script/src/python/ffi_types/py_recordbatch.rs
Codecov Report
@@ Coverage Diff @@
## develop #1339 +/- ##
===========================================
- Coverage 86.04% 86.03% -0.01%
===========================================
Files 527 528 +1
Lines 78346 78476 +130
===========================================
+ Hits 67409 67520 +111
- Misses 10937 10956 +19 |
killme2008
reviewed
Apr 10, 2023
|
@waynexia Can you take a look? |
waynexia
approved these changes
Apr 11, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: from/to numpy&collect concat * feat: PyRecordBatch * test: try import first,allow w/out numpy/pyarrow * fix: cond compile flag * doc: license * feat: sql() ret PyRecordBatch&repr * fix: after merge * style: fmt * chore: CR advices * docs: update * chore: resolve conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
PyVectorcollectto concated batch(So nocollect()[0][0]justcollect()[0]PyRecordBatchtype as return values ofPyDataFrame.collect()allowing indexing likecollected[0]orcollected["number"]Checklist
Refer to a related PR or issue link (optional)