Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: amend fmt-toml #1347

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Amend fmt-toml
  2. Rename original fmt-toml to check-toml

Format your TOML without tears 🥲

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the feat/update-makefile branch from 09eb96e to 5bf9ddb Compare April 9, 2023 05:08
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #1347 (5bf9ddb) into develop (f8b6a6b) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1347      +/-   ##
===========================================
- Coverage    85.96%   85.49%   -0.48%     
===========================================
  Files          506      509       +3     
  Lines        76892    76877      -15     
===========================================
- Hits         66103    65725     -378     
- Misses       10789    11152     +363     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 8043489 into GreptimeTeam:develop Apr 10, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants