Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for file table engine #1353

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add tests for file table engine

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #1353 (5784553) into develop (29c6155) will increase coverage by 0.08%.
The diff coverage is 99.09%.

❗ Current head 5784553 differs from pull request most recent head fc6ab7c. Consider uploading reports for the commit fc6ab7c to get more accurate results

@@             Coverage Diff             @@
##           develop    #1353      +/-   ##
===========================================
+ Coverage    85.48%   85.57%   +0.08%     
===========================================
  Files          514      517       +3     
  Lines        77414    77851     +437     
===========================================
+ Hits         66181    66620     +439     
+ Misses       11233    11231       -2     

@WenyXu WenyXu force-pushed the test/file-table-engine branch from 5784553 to fc6ab7c Compare April 11, 2023 06:09
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 enabled auto-merge (squash) April 11, 2023 06:12
@killme2008 killme2008 merged commit a90798a into GreptimeTeam:develop Apr 11, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* test: add tests for file table engine

* test: refactor open table test and add close engine test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants