refactor: merge authenticate and authorize api
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1360 +/- ##
===========================================
+ Coverage 85.49% 85.60% +0.11%
===========================================
Files 514 517 +3
Lines 77471 77834 +363
===========================================
+ Hits 66230 66629 +399
+ Misses 11241 11205 -36 |
sunng87
approved these changes
Apr 11, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: add auth api * chore: update pg using auth api * chore: update grpc using auth api * chore: update http using auth api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly introduces
authapi, which is a simple combination ofauthenticateandauthorize, but allow to be implemented for optimization. In most cases(other than MySQL auth process) it would be much easier to just useauthapi.PostgreSQL, gRPC and HTTP auth process have been refactored to use the new
authapi.Checklist
Refer to a related PR or issue link (optional)