fix: concurrent rename two table to same name may cause override

[v0y4g3r]

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix concurrent rename two table to same name may cause override

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fixes #1369

[waynexia]

🫨

[evenyag]

Does the LocalCatalogManager have a similar issue?

greptimedb/src/catalog/src/local/manager.rs

Lines 415 to 442 in 716bde8

	let schema = catalog
	.schema(schema_name)?
	.with_context(|| SchemaNotFoundSnafu {
	catalog: catalog_name,
	schema: schema_name,
	})?;
	let old_table = schema
	.table(&request.table_name)
	.await?
	.context(TableNotExistSnafu {
	table: &request.table_name,
	})?;
	let engine = old_table.table_info().meta.engine.to_string();
	// rename table in system catalog
	self.system
	.register_table(
	catalog_name.clone(),
	schema_name.clone(),
	request.new_table_name.clone(),
	request.table_id,
	engine,
	)
	.await?;
	Ok(schema
	.rename_table(&request.table_name, request.new_table_name)
	.is_ok())

Looks like we should acquire the register lock and check whether the new table exists

[codecov]

Codecov Report

Merging #1368 (1c3a499) into develop (ae21c1c) will decrease coverage by 0.28%.
The diff coverage is 65.00%.

@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
- Coverage    86.04%   85.76%   -0.28%     
===========================================
  Files          523      528       +5     
  Lines        78396    78486      +90     
===========================================
- Hits         67454    67317     -137     
- Misses       10942    11169     +227