Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add "numbers" table in distributed mode #1374

Merged

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Easy for testing. Move more sqlness tests to "common" cases.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #1294

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1374 (3ab5d43) into develop (29c6155) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1374      +/-   ##
===========================================
+ Coverage    85.48%   85.62%   +0.13%     
===========================================
  Files          514      523       +9     
  Lines        77414    78397     +983     
===========================================
+ Hits         66181    67126     +945     
- Misses       11233    11271      +38     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 0fc816f into GreptimeTeam:develop Apr 14, 2023
@MichaelScofield MichaelScofield deleted the test/frontend-numbers-table branch April 15, 2023 06:03
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "numbers" table in distributed mode as well
3 participants