Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: query prom using input query context #1381

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Apr 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly fixes a issue where prom handler uses QueryContext::arc() instead of actual input catalog and schema

@MichaelScofield
Also, I think we should check every non-test call to QueryContext::arc(). It shouldn't be called now that we have parsed catalog and schema from user input. I'll do this in a separate pr if you're ok with it

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1381 (38a72f0) into develop (0fc816f) will decrease coverage by 0.42%.
The diff coverage is 90.90%.

@@             Coverage Diff             @@
##           develop    #1381      +/-   ##
===========================================
- Coverage    86.05%   85.64%   -0.42%     
===========================================
  Files          529      529              
  Lines        78771    78783      +12     
===========================================
- Hits         67787    67470     -317     
- Misses       10984    11313     +329     

Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong merged commit bea37e3 into GreptimeTeam:develop Apr 14, 2023
@shuiyisong shuiyisong deleted the chore/fix_prom_ctx branch April 14, 2023 06:23
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants