Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some metrics #1384

Merged
merged 2 commits into from
Apr 14, 2023
Merged

feat: add some metrics #1384

merged 2 commits into from
Apr 14, 2023

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add some metrics to monitor the elapsed time of creating/altering tables.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

https://github.com/GreptimeTeam/greptimedb-cloud/issues/121

@v0y4g3r v0y4g3r marked this pull request as ready for review April 14, 2023 10:56
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1384 (9f83293) into develop (bea37e3) will decrease coverage by 0.26%.
The diff coverage is 96.29%.

@@             Coverage Diff             @@
##           develop    #1384      +/-   ##
===========================================
- Coverage    86.02%   85.77%   -0.26%     
===========================================
  Files          530      530              
  Lines        78929    78941      +12     
===========================================
- Hits         67900    67711     -189     
- Misses       11029    11230     +201     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 68e64a6 into GreptimeTeam:develop Apr 14, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: add some metrics

* fix: compile errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants