refactor: parallelize open table #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
requested review from
sunng87,
MichaelScofield,
v0y4g3r,
evenyag,
waynexia and
fengys1996
Codecov Report
@@ Coverage Diff @@
## develop #1392 +/- ##
===========================================
- Coverage 85.96% 85.42% -0.55%
===========================================
Files 531 534 +3
Lines 79240 79611 +371
===========================================
- Hits 68120 68006 -114
- Misses 11120 11605 +485 |
|
Have tested S3 backend against this branch, it's faaaaaaster than |
killme2008
reviewed
Apr 17, 2023
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Co-authored-by: dennis zhuang <killme2008@gmail.com>
|
@killme2008 PTAL |
v0y4g3r
reviewed
Apr 18, 2023
MichaelScofield
approved these changes
Apr 18, 2023
Closed
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: change open_table to parallel on datanode startup * chore: try move out register schema table * chore: change mito engine to key lock * chore: minor change * chore: minor change * chore: update error definition * chore: remove rwlock on tables * chore: try parallel register table on schema provider * chore: add rt log * chore: add region open rt log * chore: add actual open region rt log * chore: add recover rt log * chore: divide to three part rt log * chore: remove debug log * chore: add replay rt log * chore: update cargo lock * chore: remove debug log * chore: revert unused change * chore: update err msg Co-authored-by: dennis zhuang <killme2008@gmail.com> * chore: fix cr issue Co-authored-by: dennis zhuang <killme2008@gmail.com> * chore: fix cr issue * chore: fix cr issue --------- Co-authored-by: dennis zhuang <killme2008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly does
keylock(usingtable_ref.to_string()) so that lock is narrowed down to table levelfuture work
tablesandmutexinto one single function to get table ref and lock at the same returnChecklist
Refer to a related PR or issue link (optional)
close #1290