Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table scan without projection #1404

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Update datafusion to my fork that contains this commit. It allows TableScan without projection.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Closes #1396

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from v0y4g3r April 17, 2023 11:39
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1404 (8b1ab1f) into develop (408de51) will decrease coverage by 0.58%.
The diff coverage is 77.35%.

@@             Coverage Diff             @@
##           develop    #1404      +/-   ##
===========================================
- Coverage    86.00%   85.42%   -0.58%     
===========================================
  Files          533      534       +1     
  Lines        79474    79517      +43     
===========================================
- Hits         68350    67931     -419     
- Misses       11124    11586     +462     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit f4190cf into GreptimeTeam:develop Apr 17, 2023
@waynexia waynexia deleted the fix-substrait branch April 17, 2023 12:10
nearsyh pushed a commit to nearsyh/greptimedb that referenced this pull request Apr 17, 2023
* fix: table scan without projection

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* update PR reference

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: table scan without projection

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* update PR reference

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants