feat: Add metrics for cache hit/miss for object store cache #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nearsyh
changed the title
killme2008
reviewed
Apr 17, 2023
|
@nearsyh Thanks a lot for your contribution, there are some minor suggestions. |
killme2008
reviewed
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1405 +/- ##
===========================================
- Coverage 86.00% 85.42% -0.58%
===========================================
Files 533 534 +1
Lines 79474 79521 +47
===========================================
- Hits 68350 67934 -416
- Misses 11124 11587 +463 |
evenyag
reviewed
Apr 18, 2023
evenyag
reviewed
Apr 18, 2023
evenyag
approved these changes
Apr 18, 2023
|
@killme2008 Just to confirm, is there anything else I need to do for this PR? |
|
@nearsyh Thx, I'm going to merge this as all checks have passed. |
|
@nearsyh Congrats on your first PR! Thank you. |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…Team#1405) * Add the cache hit/miss counter * Verify the cache metrics are included * Resolve comments * Rename the error kind label name to be consistent with other metrics * Rename the object store metric names * Avoid using glob imports * Format the code * chore: Update src/object-store/src/metrics.rs mod doc --------- Co-authored-by: Yingwen <realevenyag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add two cache metrics to record cache hit/miss. #1276
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Note: I'm not sure about these:
Checklist
Refer to a related PR or issue link (optional)
#1276