Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update RustPython depend #1406

Merged
merged 3 commits into from
Apr 18, 2023
Merged

chore: update RustPython depend #1406

merged 3 commits into from
Apr 18, 2023

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Apr 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Update RustPython Version(with GC on) and fix compile errors

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@discord9 discord9 marked this pull request as ready for review April 17, 2023 16:50
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1406 (d999cd0) into develop (408de51) will decrease coverage by 0.11%.
The diff coverage is 76.40%.

@@             Coverage Diff             @@
##           develop    #1406      +/-   ##
===========================================
- Coverage    86.00%   85.89%   -0.11%     
===========================================
  Files          533      534       +1     
  Lines        79474    79596     +122     
===========================================
+ Hits         68350    68369      +19     
- Misses       11124    11227     +103     

py_time_poc.md Outdated Show resolved Hide resolved
src/script/Cargo.toml Show resolved Hide resolved
src/script/src/python/ffi_types/vector/tests.rs Outdated Show resolved Hide resolved
src/script/src/python/rspython/utils.rs Show resolved Hide resolved
src/script/src/python/rspython/utils.rs Outdated Show resolved Hide resolved
src/script/src/python/rspython/vector_impl.rs Show resolved Hide resolved
src/script/src/python/rspython/vector_impl.rs Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 requested a review from waynexia April 18, 2023 06:51
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have skimmed this and it generally looks good to me 👍

@waynexia waynexia merged commit de8b889 into develop Apr 18, 2023
@waynexia waynexia deleted the update_py_depend branch April 18, 2023 07:39
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* chore: update RustPython to newer version

* chore: bump ver

* chore: PR advices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants