feat: add table id and engine to information_schema.TABLES #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1407 +/- ##
===========================================
- Coverage 85.96% 85.41% -0.56%
===========================================
Files 531 534 +3
Lines 79240 79710 +470
===========================================
- Hits 68120 68083 -37
- Misses 11120 11627 +507 |
evenyag
reviewed
Apr 18, 2023
waynexia
reviewed
Apr 18, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
haohuaijin
commented
Apr 18, 2023
haohuaijin
commented
Apr 18, 2023
MichaelScofield
approved these changes
Apr 18, 2023
evenyag
approved these changes
Apr 19, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eam#1407) * feat: add table id and engine to informatin_schema.TABLES * Update src/catalog/src/information_schema/tables.rs Co-authored-by: Yingwen <realevenyag@gmail.com> * chore: change table_engine to engine * test: update sqlness for information schema * test: update information_schema test in frontend::tests::instance_test.rs * fix: github action sqlness information_schema test fail * test: ignore table_id in information_schema * test: support distribute and standalone have different output --------- Co-authored-by: Yingwen <realevenyag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
add
table_idandtable_engineto information_schema.TABLESChecklist
Refer to a related PR or issue link (optional)
close #1355