Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use alicloud imagehub #1418

Merged
merged 2 commits into from
Apr 18, 2023
Merged

chore: use alicloud imagehub #1418

merged 2 commits into from
Apr 18, 2023

Conversation

daviderli614
Copy link
Member

@daviderli614 daviderli614 commented Apr 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • delete push image to uhub
  • using alibaba cloud image hub

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1418 (8324b4e) into develop (145f8eb) will decrease coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 8324b4e differs from pull request most recent head 604ae9d. Consider uploading reports for the commit 604ae9d to get more accurate results

@@             Coverage Diff             @@
##           develop    #1418      +/-   ##
===========================================
- Coverage    85.81%   85.42%   -0.40%     
===========================================
  Files          534      534              
  Lines        79690    79669      -21     
===========================================
- Hits         68386    68054     -332     
- Misses       11304    11615     +311     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge (squash) April 18, 2023 14:19
@v0y4g3r v0y4g3r merged commit 4652b62 into GreptimeTeam:develop Apr 18, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants