Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement parsing format from hashmap #1420

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat: implement parsing format from hashmap #1420

merged 2 commits into from
Apr 19, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 19, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the feat/datasource-parser branch from 0d600f8 to f09f142 Compare April 19, 2023 03:59
@WenyXu
Copy link
Member Author

WenyXu commented Apr 19, 2023

PTAL @v0y4g3r @waynexia @evenyag @killme2008

@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Merging #1420 (8a2c803) into develop (e4cd08c) will decrease coverage by 0.42%.
The diff coverage is 79.13%.

@@             Coverage Diff             @@
##           develop    #1420      +/-   ##
===========================================
- Coverage    85.81%   85.40%   -0.42%     
===========================================
  Files          534      534              
  Lines        79722    79824     +102     
===========================================
- Hits         68411    68171     -240     
- Misses       11311    11653     +342

@evenyag evenyag mentioned this pull request Apr 19, 2023
Merged
2 tasks
evenyag
evenyag approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu requested a review from v0y4g3r April 19, 2023 07:58
v0y4g3r
v0y4g3r approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 5a05e31 into GreptimeTeam:develop Apr 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@WenyXu @paomian
feat: implement parsing format from hashmap (GreptimeTeam#1420)
c933d41 
* feat: implement parsing format from hashmap

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@v0y4g3r v0y4g3r v0y4g3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @v0y4g3r @evenyag