-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: store raw objname internally #2719
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2719 +/- ##
===========================================
- Coverage 85.17% 84.79% -0.39%
===========================================
Files 765 765
Lines 123911 123933 +22
===========================================
- Hits 105545 105089 -456
- Misses 18366 18844 +478 |
Do you mind to add some sqlness test to cover this scenario? Thanks. |
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other names (table name) are handled by table_idents_to_full_name
which omits quote style also.
@waynexia OK. How can I run a specify sqlness test case? |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Anyway, updated. |
|
@waynexia OK. You may give another review. This PR is ready IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tisonkun
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch fixes #2595.
It's still a quick fix but not a hack. I'm going to go through other similar code path and trying to add a test if possible. But submit this PR for early review if any.Checklist
Refer to a related PR or issue link (optional)