Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store raw objname internally #2719

Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix: store raw objname internally #2719

merged 4 commits into from
Nov 10, 2023

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Nov 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch fixes #2595.

It's still a quick fix but not a hack. I'm going to go through other similar code path and trying to add a test if possible. But submit this PR for early review if any.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: tison <wander4096@gmail.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2719 (329250e) into develop (93f21b1) will decrease coverage by 0.39%.
The diff coverage is 96.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2719      +/-   ##
===========================================
- Coverage    85.17%   84.79%   -0.39%     
===========================================
  Files          765      765              
  Lines       123911   123933      +22     
===========================================
- Hits        105545   105089     -456     
- Misses       18366    18844     +478     

@waynexia
Copy link
Member

waynexia commented Nov 9, 2023

Do you mind to add some sqlness test to cover this scenario? Thanks.

Signed-off-by: tison <wander4096@gmail.com>
Copy link
Collaborator Author

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other names (table name) are handled by table_idents_to_full_name which omits quote style also.

@tisonkun
Copy link
Collaborator Author

tisonkun commented Nov 9, 2023

Do you mind to add some sqlness test to cover this scenario? Thanks.

@waynexia OK. How can I run a specify sqlness test case? cargo sqlness seems run all the tests.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Collaborator Author

tisonkun commented Nov 9, 2023

Anyway, updated.

@waynexia
Copy link
Member

waynexia commented Nov 9, 2023

Do you mind to add some sqlness test to cover this scenario? Thanks.

@waynexia OK. How can I run a specify sqlness test case? cargo sqlness seems run all the tests.

cargo sqlness -t create_database should do that for you. You can use cargo sqlness --help to see the manual.

@tisonkun
Copy link
Collaborator Author

tisonkun commented Nov 9, 2023

@waynexia OK. You may give another review. This PR is ready IMO.

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tisonkun

@waynexia waynexia added this pull request to the merge queue Nov 10, 2023
Merged via the queue into GreptimeTeam:develop with commit 8fd0766 Nov 10, 2023
14 checks passed
@tisonkun tisonkun deleted the store-raw-objname branch November 10, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal SchemaNameKey format: '__schema_name/greptime/'illegal-database''
3 participants