feat!: do not get TZ info from server local env #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
commented
Dec 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2905 +/- ##
===========================================
- Coverage 85.01% 84.52% -0.50%
===========================================
Files 753 756 +3
Lines 118592 119453 +861
===========================================
+ Hits 100820 100966 +146
- Misses 17772 18487 +715 |
|
@waynexia Is this a breaking change? |
waynexia
changed the title
github-actions
bot
added
the
breaking-change
Yes, I've changed the title |
13 tasks
MichaelScofield
approved these changes
Dec 12, 2023
|
A user says he's using Influxdb line protocol with explicit timestamp to write, and read with timestamp (instead of the date time like "2023-12-12 17:45:00"). So I think this breaking change is fine. |
killme2008
approved these changes
Dec 12, 2023
|
Let's move on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Remove the logic of fetching server's local timezone as the default timezone. Use Zulu (UTC+0) by default. We can provide a method to set per-session timezone in the future, as requested in #2893
Warning
This is a breaking change. After this patch, the server-side timezone will default to GMT instead of environment
$TZ. It would be configurable in the future (#2907)Checklist
Refer to a related PR or issue link (optional)
Closes #2856
Part of #2907