Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: builder to vector without resetting #2915

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Dec 12, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

main changes:

  • add new method named finish_cloned in ScalarVectorBuilder trait
  • add new method named to_vector_cloned in MutableVector trait.
  • some unit tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #2915 (19abe51) into develop (58183fe) will decrease coverage by 0.48%.
Report is 19 commits behind head on develop.
The diff coverage is 93.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2915      +/-   ##
===========================================
- Coverage    85.01%   84.54%   -0.48%     
===========================================
  Files          753      750       -3     
  Lines       118592   119261     +669     
===========================================
+ Hits        100820   100828       +8     
- Misses       17772    18433     +661     

@QuenKar QuenKar requested a review from evenyag December 12, 2023 08:29
@evenyag evenyag requested a review from v0y4g3r December 13, 2023 03:04
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/datatypes/src/scalars.rs Outdated Show resolved Hide resolved
src/datatypes/src/scalars.rs Outdated Show resolved Hide resolved
Co-authored-by: Yingwen <realevenyag@gmail.com>
@evenyag evenyag added this pull request to the merge queue Dec 13, 2023
Merged via the queue into GreptimeTeam:develop with commit fec3fcf Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants