Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose region migration http endpoint #3032

Merged
merged 6 commits into from
Dec 29, 2023
Merged

feat: expose region migration http endpoint #3032

merged 6 commits into from
Dec 29, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Expose region migration http endpoint
  2. Implement naive peer registry

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@github-actions github-actions bot added docs-required This change requires docs update. Size: M labels Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (1d80a0f) 85.76% compared to head (23c4d6d) 85.02%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3032      +/-   ##
==========================================
- Coverage   85.76%   85.02%   -0.74%     
==========================================
  Files         791      793       +2     
  Lines      127985   128562     +577     
==========================================
- Hits       109760   109316     -444     
- Misses      18225    19246    +1021

@WenyXu WenyXu self-assigned this Dec 28, 2023
@WenyXu WenyXu mentioned this pull request Dec 28, 2023
Closed
39 tasks
@WenyXu WenyXu force-pushed the feat/region-migration-http-endpoint branch from 0ad8aad to 23c4d6d Compare December 29, 2023 04:51
@WenyXu
Copy link
Member Author

WenyXu commented Dec 29, 2023

@MichaelScofield @fengjiachun PTAL

fengjiachun
fengjiachun approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/meta-srv/src/cluster.rs Show resolved Hide resolved
@WenyXu WenyXu mentioned this pull request Dec 29, 2023
Closed
@fengjiachun fengjiachun added this pull request to the merge queue Dec 29, 2023
Merged via the queue into GreptimeTeam:main with commit d22072f Dec 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengys1996 fengys1996 Awaiting requested review from fengys1996

Assignees

@WenyXu WenyXu

Labels
docs-required This change requires docs update.
Projects
Migration Procedure
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @MichaelScofield @fengjiachun