refactor: make grpc service able to be added dynamically #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3160 +/- ##
==========================================
- Coverage 85.43% 84.89% -0.55%
==========================================
Files 823 824 +1
Lines 134979 134945 -34
==========================================
- Hits 115320 114556 -764
- Misses 19659 20389 +730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Sometimes in other projects, we need to add another grpc service to tonic server. This PR refactor the grpc codes to enable that.
Checklist
Refer to a related PR or issue link (optional)