-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: switch prom remote write to metric engine #3198
feat!: switch prom remote write to metric engine #3198
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
==========================================
- Coverage 85.82% 85.44% -0.38%
==========================================
Files 840 840
Lines 137704 137920 +216
==========================================
- Hits 118183 117849 -334
- Misses 19521 20071 +550 |
What about using a query parameter instead of an HTTP header?
It doesn't feel right as an HTTP header; it's actually a request parameter. |
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
BTW this is not a breaking change. It won't affect existing remote write. Only new metrics will be created in metric engine |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
From the user's perspective, the behavior is changed after upgrading. And if we don't provide a default physical table name, the users must change theirs Prometheus setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Run PromStore with metric engine.
All tables created from prom remote write will use metric engine automatically if the config
[prom_store].with_metric_engine
is set totrue
. This PR adds a new parameter to prometheus request URLphysical-table
for prom remote write to specify which physical table to use. And the default physical table name isgreptime_physical_table
.An example of this URL is
http://172.17.0.1:4000/v1/prometheus/write?physical_table=my_table_name
Checklist
Refer to a related PR or issue link (optional)