Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create alter table expr translator #3203

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 19, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add alter table expr translator
  2. Add create table expr translator

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3174

@github-actions github-actions bot added Size: M docs-not-required This change does not impact docs. labels Jan 19, 2024
@github-actions github-actions bot added Size: XL and removed Size: M labels Jan 20, 2024
@WenyXu WenyXu force-pushed the feat/tests-fuzz branch 2 times, most recently from 25b4c52 to 9e7a98a Compare January 20, 2024 05:03
@WenyXu WenyXu marked this pull request as ready for review January 20, 2024 05:04
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (440cd00) 85.86% compared to head (88792c4) 85.33%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   85.86%   85.33%   -0.53%     
==========================================
  Files         839      844       +5     
  Lines      137421   138151     +730     
==========================================
- Hits       117990   117892      -98     
- Misses      19431    20259     +828     

Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests-fuzz/tests/main.rs Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Jan 23, 2024
Merged via the queue into GreptimeTeam:main with commit 364754a Jan 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants