Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename initialize_region_in_background to init_regions_in_background #3216

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 22, 2024

I hereby agree to the terms of the GreptimeDB CLA

Rename initialize_region_in_background to init_regions_in_background

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. breaking-change This pull request contains breaking changes. Size: S labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bf4b08) 85.82% compared to head (3a72c6d) 85.42%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
- Coverage   85.82%   85.42%   -0.40%     
==========================================
  Files         840      840              
  Lines      137704   138162     +458     
==========================================
- Hits       118183   118026     -157     
- Misses      19521    20136     +615     

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 23, 2024
Merged via the queue into GreptimeTeam:main with commit 19413eb Jan 23, 2024
22 checks passed
@tisonkun tisonkun changed the title refactor!: rename initialize_region_in_background to init_regions_in_background refactor!: rename initialize_region_in_background to init_regions_in_background Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants