Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix default value cannot accept negative number #3217

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix default value cannot accept negative number

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

close #3204

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 23, 2024
@WenyXu WenyXu force-pushed the fix/fix-negative-default-value branch from 2e1b1c3 to a5d5eb2 Compare January 23, 2024 02:40
@WenyXu WenyXu marked this pull request as draft January 23, 2024 02:46
@WenyXu WenyXu force-pushed the fix/fix-negative-default-value branch from a5d5eb2 to 8a7635b Compare January 23, 2024 02:47
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the fix/fix-negative-default-value branch from 8a7635b to fe0ba20 Compare January 23, 2024 02:58
@WenyXu WenyXu marked this pull request as ready for review January 23, 2024 02:58
Copy link
Contributor

@QuenKar QuenKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the fix/fix-negative-default-value branch from fe0ba20 to 928ce7e Compare January 23, 2024 03:08
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (31787f4) 85.90% compared to head (b6107f6) 85.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
- Coverage   85.90%   85.45%   -0.46%     
==========================================
  Files         840      844       +4     
  Lines      138162   138618     +456     
==========================================
- Hits       118691   118451     -240     
- Misses      19471    20167     +696     

@killme2008 killme2008 added this pull request to the merge queue Jan 23, 2024
Merged via the queue into GreptimeTeam:main with commit 007b63d Jan 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create table with negative default value
4 participants