Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't map semantic type in metric engine #3243

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Avoid memory problem caused by null fields. By not mapping tag to field in metric engine.

Peak memory drops from ~24GB to ~10GB
image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 26, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@killme2008 killme2008 enabled auto-merge January 26, 2024 03:45
@killme2008 killme2008 added this pull request to the merge queue Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8485c9a) 85.86% compared to head (0ac984d) 85.17%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3243      +/-   ##
==========================================
- Coverage   85.86%   85.17%   -0.69%     
==========================================
  Files         844      856      +12     
  Lines      138631   140066    +1435     
==========================================
+ Hits       119034   119300     +266     
- Misses      19597    20766    +1169     

Merged via the queue into GreptimeTeam:main with commit b0c3be3 Jan 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants