Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust storage engine related metrics #3261

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As title. This patch mainly focus on metrics in mito and metric engine

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e5a2b04) 85.78% compared to head (531b8d0) 85.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
- Coverage   85.78%   85.34%   -0.45%     
==========================================
  Files         856      856              
  Lines      140188   140205      +17     
==========================================
- Hits       120261   119655     -606     
- Misses      19927    20550     +623     

@waynexia waynexia enabled auto-merge January 30, 2024 06:10
@waynexia waynexia added this pull request to the merge queue Jan 30, 2024
Merged via the queue into GreptimeTeam:main with commit a079955 Jan 30, 2024
16 checks passed
@waynexia waynexia deleted the add-metrics branch January 30, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants