Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Basic Definitions for Expression&Functions for Dataflow #3267

Merged
merged 18 commits into from
Feb 5, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Jan 30, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Added following types that are worth noting:

  • ScalarExpr: expressions in dataflow framework

  • UnaryFunc, BinaryFunc, VariadicFunc & UnmaterializableFunc: function used in the ScalarExpr

  • AggregateExpr&AggregateFunc: describing aggregate function and expressions, including basic function for accumlatoring aggregate results

  • MapFilterProject: map, filter and project, including temporal filter that compare with now() system time.

  • Summarize your change
    Basically a lot of utility function&types to support dataflow computation

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: XL labels Jan 30, 2024
@discord9 discord9 marked this pull request as ready for review January 30, 2024 10:55
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0a9361a) 85.63% compared to head (487bc38) 85.65%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   85.63%   85.65%   +0.01%     
==========================================
  Files         859      865       +6     
  Lines      140515   140798     +283     
==========================================
+ Hits       120333   120598     +265     
- Misses      20182    20200      +18     

@killme2008
Copy link
Contributor

Please associate this PR with the tracking issue task.

@discord9 discord9 marked this pull request as draft January 31, 2024 03:38
@discord9 discord9 marked this pull request as ready for review January 31, 2024 09:51
@discord9 discord9 marked this pull request as draft February 4, 2024 09:16
@discord9 discord9 changed the title feat: Expression&Functions for Dataflow feat: Basic Definitions for Expression&Functions for Dataflow Feb 4, 2024
@github-actions github-actions bot added Size: M and removed Size: XL labels Feb 4, 2024
@discord9 discord9 marked this pull request as ready for review February 4, 2024 10:48
@github-actions github-actions bot added Size: L and removed Size: M labels Feb 5, 2024
@discord9 discord9 force-pushed the dataflow_p1_expr_func branch from d45ca68 to f0f8380 Compare February 5, 2024 03:30
@github-actions github-actions bot added Size: M and removed Size: XL labels Feb 5, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator

CI is failed @discord9

@zhongzc zhongzc added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit c62c67c Feb 5, 2024
17 checks passed
@zhongzc zhongzc deleted the dataflow_p1_expr_func branch February 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants