-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Basic Definitions for Expression&Functions for Dataflow #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
This change does not impact docs.
Size: XL
labels
Jan 30, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 85.63% 85.65% +0.01%
==========================================
Files 859 865 +6
Lines 140515 140798 +283
==========================================
+ Hits 120333 120598 +265
- Misses 20182 20200 +18 |
Please associate this PR with the tracking issue task. |
19 tasks
killme2008
requested review from
zhongzc,
waynexia,
killme2008 and
fengjiachun
February 2, 2024 08:02
discord9
changed the title
feat: Expression&Functions for Dataflow
feat: Basic Definitions for Expression&Functions for Dataflow
Feb 4, 2024
discord9
force-pushed
the
dataflow_p1_expr_func
branch
from
February 5, 2024 03:30
d45ca68
to
f0f8380
Compare
fengjiachun
reviewed
Feb 5, 2024
fengjiachun
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI is failed @discord9 |
zhongzc
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Added following types that are worth noting:
ScalarExpr
: expressions in dataflow frameworkUnaryFunc
,BinaryFunc
,VariadicFunc
&UnmaterializableFunc
: function used in theScalarExpr
AggregateExpr
&AggregateFunc
: describing aggregate function and expressions, including basic function for accumlatoring aggregate resultsMapFilterProject
: map, filter and project, including temporal filter that compare withnow()
system time.Summarize your change
Basically a lot of utility function&types to support dataflow computation
Checklist
Refer to a related PR or issue link (optional)