Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cache for batch_get in CachedMetaKvBackend #3277

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

fengys1996
Copy link
Contributor

@fengys1996 fengys1996 commented Feb 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As title says: this pr mainly support cache for batch_get in CachedMetaKvBackend.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added Size: M docs-not-required This change does not impact docs. labels Feb 4, 2024
@fengys1996 fengys1996 marked this pull request as ready for review February 4, 2024 08:00
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (3201aea) 85.78% compared to head (ebdc96d) 85.21%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
- Coverage   85.78%   85.21%   -0.58%     
==========================================
  Files         856      865       +9     
  Lines      140170   141005     +835     
==========================================
- Hits       120251   120153      -98     
- Misses      19919    20852     +933     

config/frontend.example.toml Outdated Show resolved Hide resolved
config/frontend.example.toml Outdated Show resolved Hide resolved
config/frontend.example.toml Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Show resolved Hide resolved
src/meta-client/src/lib.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor Author

@fengjiachun PTAL

src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/catalog/src/kvbackend/client.rs Show resolved Hide resolved
src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor Author

@niebayes PTAL

@niebayes niebayes enabled auto-merge February 6, 2024 03:14
@niebayes niebayes added this pull request to the merge queue Feb 6, 2024
Merged via the queue into GreptimeTeam:main with commit 74bfb09 Feb 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants