-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cache for batch_get in CachedMetaKvBackend #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Size: M
docs-not-required
This change does not impact docs.
labels
Feb 4, 2024
fengys1996
force-pushed
the
feat/batch_get
branch
from
February 4, 2024 07:24
3c898c7
to
2c2302c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3277 +/- ##
==========================================
- Coverage 85.78% 85.21% -0.58%
==========================================
Files 856 865 +9
Lines 140170 141005 +835
==========================================
- Hits 120251 120153 -98
- Misses 19919 20852 +933 |
fengys1996
requested review from
MichaelScofield,
niebayes,
zyy17,
fengjiachun and
shuiyisong
February 4, 2024 09:37
fengjiachun
reviewed
Feb 4, 2024
@fengjiachun PTAL |
fengjiachun
reviewed
Feb 5, 2024
fengjiachun
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
niebayes
reviewed
Feb 5, 2024
@niebayes PTAL |
niebayes
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
As title says: this pr mainly support cache for batch_get in CachedMetaKvBackend.
Checklist
Refer to a related PR or issue link (optional)