Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl partitions and region_peers information schema #3278

Merged

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Feb 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Adds two new information schemas to provide table partitions and regions distribution info:

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Feb 4, 2024
@killme2008 killme2008 changed the title feat: impl partitions table feat: impl partitions and region_peers information schema Feb 7, 2024
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Feb 7, 2024
@killme2008 killme2008 mentioned this pull request Feb 7, 2024
37 tasks
@killme2008 killme2008 marked this pull request as ready for review February 7, 2024 06:36
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 375 lines in your changes are missing coverage. Please review.

Comparison is base (2a26c01) 85.53% compared to head (e0200d9) 84.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3278      +/-   ##
==========================================
- Coverage   85.53%   84.92%   -0.62%     
==========================================
  Files         872      874       +2     
  Lines      141967   142480     +513     
==========================================
- Hits       121434   120995     -439     
- Misses      20533    21485     +952     

@github-actions github-actions bot added Size: XL and removed Size: L labels Feb 7, 2024
@killme2008 killme2008 force-pushed the feature/information-schema-part6 branch from c763406 to 9c37fc4 Compare February 12, 2024 07:34
@killme2008 killme2008 requested a review from zhongzc February 16, 2024 08:29
@github-actions github-actions bot added Size: XL and removed Size: L labels Feb 18, 2024
@killme2008
Copy link
Contributor Author

@WenyXu @fengjiachun PTAL

@killme2008 killme2008 force-pushed the feature/information-schema-part6 branch from 78bba13 to e0200d9 Compare February 18, 2024 12:32
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Feb 19, 2024
Merged via the queue into GreptimeTeam:main with commit 8b73067 Feb 19, 2024
16 checks passed
@killme2008 killme2008 deleted the feature/information-schema-part6 branch February 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants