-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl partitions and region_peers information schema #3278
Merged
fengjiachun
merged 10 commits into
GreptimeTeam:main
from
killme2008:feature/information-schema-part6
Feb 19, 2024
Merged
feat: impl partitions and region_peers information schema #3278
fengjiachun
merged 10 commits into
GreptimeTeam:main
from
killme2008:feature/information-schema-part6
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
This change does not impact docs.
Size: L
labels
Feb 4, 2024
killme2008
changed the title
feat: impl partitions table
feat: impl partitions and region_peers information schema
Feb 7, 2024
github-actions
bot
added
docs-required
This change requires docs update.
and removed
docs-not-required
This change does not impact docs.
labels
Feb 7, 2024
37 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3278 +/- ##
==========================================
- Coverage 85.53% 84.92% -0.62%
==========================================
Files 872 874 +2
Lines 141967 142480 +513
==========================================
- Hits 121434 120995 -439
- Misses 20533 21485 +952 |
zhongzc
reviewed
Feb 7, 2024
killme2008
force-pushed
the
feature/information-schema-part6
branch
from
February 12, 2024 07:34
c763406
to
9c37fc4
Compare
fengjiachun
reviewed
Feb 18, 2024
WenyXu
reviewed
Feb 18, 2024
@WenyXu @fengjiachun PTAL |
killme2008
force-pushed
the
feature/information-schema-part6
branch
from
February 18, 2024 12:32
78bba13
to
e0200d9
Compare
WenyXu
approved these changes
Feb 19, 2024
fengjiachun
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Adds two new information schemas to provide table partitions and regions distribution info:
partitions
just like MySQL partitions with an extralgreptime_region_id
column.greptime_region_peers
just liketikv_region_peers
https://docs.pingcap.com/tidb/stable/information-schema-tikv-region-peersChecklist
Refer to a related PR or issue link (optional)
#2931