Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mito): add options to ignore building index for specific column ids #3295

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Feb 7, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add options to mito region, e.g.

index.inverted_index.ignore_column_ids: 1,2,3

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M and removed docs-not-required This change does not impact docs. labels Feb 7, 2024
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (141ed51) 85.54% compared to head (e1cab96) 85.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
- Coverage   85.54%   85.13%   -0.41%     
==========================================
  Files         872      872              
  Lines      141688   141904     +216     
==========================================
- Hits       121200   120812     -388     
- Misses      20488    21092     +604     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito2/src/region/options.rs Show resolved Hide resolved
src/mito2/src/sst/index/creator.rs Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Sorry for the slow review.

src/mito2/src/region/options.rs Show resolved Hide resolved
@evenyag evenyag added this pull request to the merge queue Feb 16, 2024
Merged via the queue into GreptimeTeam:main with commit f9ce270 Feb 16, 2024
16 checks passed
@zhongzc zhongzc deleted the zhongzc/index-ignore-column-ids branch February 18, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants