Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data buffer and related structs #3329

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 19, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add impl for the data buffer related structs for MergeTreeMemtable.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r marked this pull request as ready for review February 19, 2024 14:58
@v0y4g3r v0y4g3r requested a review from evenyag February 19, 2024 14:58
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 19, 2024
@v0y4g3r v0y4g3r requested a review from fengjiachun February 19, 2024 14:58
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (43fd87e) 85.23% compared to head (6e778fa) 84.87%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3329      +/-   ##
==========================================
- Coverage   85.23%   84.87%   -0.36%     
==========================================
  Files         878      881       +3     
  Lines      143009   143843     +834     
==========================================
+ Hits       121896   122093     +197     
- Misses      21113    21750     +637     

src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

@evenyag evenyag enabled auto-merge February 20, 2024 09:20
@evenyag evenyag added this pull request to the merge queue Feb 20, 2024
Merged via the queue into GreptimeTeam:main with commit 450dfe3 Feb 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants