-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data buffer and related structs #3329
Merged
evenyag
merged 6 commits into
GreptimeTeam:main
from
v0y4g3r:feat/merge-tree-data-buffer
Feb 20, 2024
Merged
feat: data buffer and related structs #3329
evenyag
merged 6 commits into
GreptimeTeam:main
from
v0y4g3r:feat/merge-tree-data-buffer
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3329 +/- ##
==========================================
- Coverage 85.23% 84.87% -0.36%
==========================================
Files 878 881 +3
Lines 143009 143843 +834
==========================================
+ Hits 121896 122093 +197
- Misses 21113 21750 +637 |
evenyag
reviewed
Feb 20, 2024
fengjiachun
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
evenyag
approved these changes
Feb 20, 2024
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add impl for the data buffer related structs for
MergeTreeMemtable
.Checklist
Refer to a related PR or issue link (optional)