-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge tree dedup reader #3375
feat: merge tree dedup reader #3375
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3375 +/- ##
==========================================
- Coverage 85.59% 85.18% -0.41%
==========================================
Files 892 893 +1
Lines 146564 146815 +251
==========================================
- Hits 125448 125070 -378
- Misses 21116 21745 +629 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR:
dedup
config toShard
/ShardBuilder/DataBuffer
etc. to control whether rows with duplicate ts should be removedDedupReader
so that we can remove duplicated rows among different data batches.Checklist
Refer to a related PR or issue link (optional)