Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add builder result outputs in release action #3381

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

daviderli614
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Notification job cannot get build result in this checker:

if: ${{ needs.release-images-to-dockerhub.outputs.build-image-result == 'success' && needs.build-windows-artifacts.outputs.build-windows-result == 'success' && needs.build-macos-artifacts.outputs.build-macos-result == 'success' }}

$GITHUB_OUTPUT share between job but need to define outputs, like this.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@daviderli614 daviderli614 requested review from MichaelScofield and zyy17 and removed request for MichaelScofield February 26, 2024 03:47
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (e481f07) to head (c173c67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3381      +/-   ##
==========================================
- Coverage   85.67%   85.25%   -0.42%     
==========================================
  Files         893      893              
  Lines      147247   147247              
==========================================
- Hits       126152   125535     -617     
- Misses      21095    21712     +617     

@zyy17 zyy17 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into GreptimeTeam:main with commit 8e3e0fd Feb 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants