-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use a partition level map to look up pk index #3400
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3400 +/- ##
==========================================
- Coverage 85.04% 84.54% -0.50%
==========================================
Files 893 899 +6
Lines 147899 148520 +621
==========================================
- Hits 125781 125567 -214
- Misses 22118 22953 +835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds a partition level map to replace the shard level map to look up pk indices. This can improve pk index lookup performance as we don't need to iterate all shards to find the pk index.
This PR also fixes an issue that a key may be written to multiple shards if we find the key before finishing a shard builder.
Checklist
Refer to a related PR or issue link (optional)