feat: enable ArrowFlight compression #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Feb 28, 2024
Comment on lines
+54
to
+55
| .try_with_compression(Some(arrow::ipc::CompressionType::LZ4_FRAME)) | ||
| .unwrap(); |
There was a problem hiding this comment.
Always Ok because the default option has metadata_version = MetadataVersion::V5.
But I'm a bit hesitate if we should hard code the compression type here, while I agree that we don't need to make it configurable. Fortunately, the receiver (reader) side would determinate the compression type and do the necessary decompresson work.
Signed-off-by: tison <wander4096@gmail.com>
MichaelScofield
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
==========================================
- Coverage 85.03% 84.63% -0.40%
==========================================
Files 889 889
Lines 146153 146326 +173
==========================================
- Hits 124281 123848 -433
- Misses 21872 22478 +606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This closes #1445.
Although the issue suggests we enable compression for gRPC services also, I noticed that we are now initiating a lot of gRPC services. We may instead first sort out them so that we can determinate which services can turn on this feature and how their clients communicate with them.
Checklist
Refer to a related PR or issue link (optional)