-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Reduce decode overhead during pruning keys in the memtable #3415
Conversation
chore: fix compiler errors refactor: shard prune metrics
ebd00b0
to
69bdbf0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
- Coverage 85.05% 84.72% -0.33%
==========================================
Files 889 889
Lines 146427 146709 +282
==========================================
- Hits 124547 124303 -244
- Misses 21880 22406 +526 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR improves the pruning speed of the new memtable
decode_value_at()
method to decode a value at a specific position in the primary keyPrimaryKeyFilter
to filter primary keys viadecode_value_at()
Shards
andShardBuilder
to reduce DataBatch returned to the partition readerChecklist
Refer to a related PR or issue link (optional)