Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce a clone of string #3422

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title said

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.60%. Comparing base (8609977) to head (4a993cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   85.01%   84.60%   -0.42%     
==========================================
  Files         889      889              
  Lines      146574   146596      +22     
==========================================
- Hits       124613   124028     -585     
- Misses      21961    22568     +607     

@tisonkun tisonkun added this pull request to the merge queue Mar 3, 2024
Merged via the queue into GreptimeTeam:main with commit 0edf1bb Mar 3, 2024
16 checks passed
@fengjiachun fengjiachun deleted the feat/reduce-clone-string branch March 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants