Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: show tables and show databases #3423

Merged

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Mar 3, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3354

What's changed and what's your intention?

Main changes:

  • Make show tables and show databases to query data from information_schema tables.
  • Fixed where clause can't work properly, SHOW FULL TABLES WHERE Table_type != 'VIEW' for example.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 3, 2024
@killme2008 killme2008 marked this pull request as ready for review March 3, 2024 15:49
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 93.12977% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 84.67%. Comparing base (2a675e0) to head (93fd61f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
- Coverage   85.00%   84.67%   -0.33%     
==========================================
  Files         889      889              
  Lines      146596   146488     -108     
==========================================
- Hits       124613   124044     -569     
- Misses      21983    22444     +461     

@killme2008 killme2008 requested a review from waynexia March 4, 2024 03:07
@shuiyisong shuiyisong added this pull request to the merge queue Mar 4, 2024
Merged via the queue into GreptimeTeam:main with commit e681941 Mar 4, 2024
21 of 29 checks passed
@killme2008 killme2008 deleted the feat/refactor-show-tables-databases branch March 4, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants