Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make MergeTreeMemtable the default choice #3430

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Mar 5, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#2804

What's changed and what's your intention?

Though still in experimental stage, we can replace TimeSeriesMemtable with MergeTreeMemtable.

This PR also modifies some of the default config of MergeTreeMemtable.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 5, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review March 5, 2024 08:10
@v0y4g3r v0y4g3r requested a review from evenyag March 5, 2024 08:11
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.72%. Comparing base (4915786) to head (39938d7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   85.09%   84.72%   -0.38%     
==========================================
  Files         889      890       +1     
  Lines      146519   146093     -426     
==========================================
- Hits       124677   123770     -907     
- Misses      21842    22323     +481     

@evenyag evenyag mentioned this pull request Mar 5, 2024
8 tasks
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun enabled auto-merge March 5, 2024 09:54
@fengjiachun fengjiachun added this pull request to the merge queue Mar 5, 2024
Merged via the queue into GreptimeTeam:main with commit 7183fa1 Mar 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants