Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bin opt to build cmd #3440

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add bin opt to build cmd.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (5d644c0) to head (4fdf818).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3440      +/-   ##
==========================================
- Coverage   85.44%   85.06%   -0.39%     
==========================================
  Files         895      895              
  Lines      147091   147093       +2     
==========================================
- Hits       125680   125119     -561     
- Misses      21411    21974     +563     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

May I ask where you find the necessity, i.e., in what workflow you'd like to change bin name.

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 6, 2024
Merged via the queue into GreptimeTeam:main with commit c52bc61 Mar 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants