Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce wal benchmarker #3446

Merged
merged 16 commits into from
Apr 3, 2024
Merged

feat: introduce wal benchmarker #3446

merged 16 commits into from
Apr 3, 2024

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Mar 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Introduce the wal benchmarker for benchmarking the wal component.
  • Add some prometheus metrics for log store.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@niebayes niebayes added the docs-not-required This change does not impact docs. label Mar 6, 2024
@niebayes niebayes self-assigned this Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 15.63089% with 448 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (4a5bb69) to head (81b7058).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
- Coverage   85.38%   84.80%   -0.58%     
==========================================
  Files         932      939       +7     
  Lines      155596   156879    +1283     
==========================================
+ Hits       132857   133043     +186     
- Misses      22739    23836    +1097

MichaelScofield
MichaelScofield reviewed Mar 7, 2024
View reviewed changes
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/wal.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka.rs Outdated Show resolved Hide resolved
src/log-store/src/raft_engine.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor

@v0y4g3r @WenyXu Please take a look

@WenyXu
Copy link
Member

WenyXu commented Mar 29, 2024

There are some conflicts

@niebayes niebayes force-pushed the feat/wal_benchmarker branch from 6d90bd4 to 91c9b9f Compare March 29, 2024 02:58
v0y4g3r
v0y4g3r reviewed Mar 29, 2024
View reviewed changes
benchmarks/config/wal_bench.example.toml Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
benchmarks/src/bin/wal.rs Outdated Show resolved Hide resolved
@niebayes niebayes force-pushed the feat/wal_benchmarker branch 2 times, most recently from 113323f to 836c3a1 Compare March 29, 2024 09:29
@niebayes niebayes force-pushed the feat/wal_benchmarker branch from 836c3a1 to f27f9d0 Compare March 30, 2024 02:52
@v0y4g3r
Copy link
Contributor

v0y4g3r commented Apr 1, 2024

Generally LGTM. Can we rename the binary name from wal to wal_bench?

@niebayes niebayes requested a review from v0y4g3r April 1, 2024 09:55
v0y4g3r
v0y4g3r approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge April 2, 2024 12:00
@v0y4g3r v0y4g3r added this pull request to the merge queue Apr 3, 2024
Merged via the queue into GreptimeTeam:main with commit d33435f Apr 3, 2024
26 checks passed
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees

@niebayes niebayes

Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niebayes @killme2008 @WenyXu @v0y4g3r @MichaelScofield