Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: max-txn-ops option #3458

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add max_txn_ops option for metasrv. If using etcd as the store, this value should be less than or equal to the --max-txn-ops option value of etcd. If using another store, this option can be ignored.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 7, 2024
@fengjiachun fengjiachun force-pushed the feat/max-txn-ops-limit branch from 67ed364 to 4351690 Compare March 7, 2024 13:35
@fengjiachun fengjiachun force-pushed the feat/max-txn-ops-limit branch from 4351690 to c9ff08e Compare March 7, 2024 14:10
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 87.14286% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 85.02%. Comparing base (a218f12) to head (7688270).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3458      +/-   ##
==========================================
- Coverage   85.42%   85.02%   -0.41%     
==========================================
  Files         896      896              
  Lines      147137   147236      +99     
==========================================
- Hits       125696   125190     -506     
- Misses      21441    22046     +605     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

src/common/meta/src/kv_backend/etcd.rs Outdated Show resolved Hide resolved
src/meta-srv/src/metasrv.rs Show resolved Hide resolved
src/meta-srv/src/metasrv.rs Outdated Show resolved Hide resolved
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge March 8, 2024 02:28
@waynexia waynexia added this pull request to the merge queue Mar 8, 2024
Merged via the queue into GreptimeTeam:main with commit 352bd7b Mar 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants